Skip to content

Expose "unparse", FormatNode and RawAST#710

Merged
sparkprime merged 3 commits into
google:masterfrom
charleskorn:expose-unparse
Jun 14, 2023
Merged

Expose "unparse", FormatNode and RawAST#710
sparkprime merged 3 commits into
google:masterfrom
charleskorn:expose-unparse

Conversation

@charleskorn
Copy link
Copy Markdown
Contributor

@charleskorn charleskorn commented Jun 14, 2023

This is a rebased version of #530 by @tomwilkie:

(Opening this for discussion, see #389)

I've build a little tool that does some modifications to jsonnet files (updating docker image versions in them), and wanted to use the pretty-printing code to write out the modified AST.

This is a minimal set of changes that allow me to do that.

tomwilkie added 3 commits June 13, 2023 16:51
@tomwilkie @charleskorn
Export FormatNode so external users can pretty print an AST
39a8a10 
Signed-off-by: Tom Wilkie <tom@grafana.com>
@tomwilkie @charleskorn
Expose RawAST function.
1945af3 
Signed-off-by: Tom Wilkie <tom@grafana.com>
@tomwilkie @charleskorn
Add comment
3ed30fb 
Signed-off-by: Tom Wilkie <tom@grafana.com>
@charleskorn charleskorn mentioned this pull request Jun 14, 2023
Closed
@sparkprime
Copy link
Copy Markdown
Contributor

sparkprime commented Jun 14, 2023

This does not produce any go_sdk headers files failure I've seen before. I think I fixed it by bumping the version of the bazel/golang integration package that we use.

@sparkprime
Copy link
Copy Markdown
Contributor

sparkprime commented Jun 14, 2023

I would merge this without worrying about the failing bazel test though... That can be fixed independently.

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 14, 2023

Coverage Status

coverage: 68.568%. remained the same when pulling 3ed30fb on charleskorn:expose-unparse into 9639773 on google:master.

@sparkprime sparkprime merged commit 7b9f5fd into google:master Jun 14, 2023
@charleskorn charleskorn deleted the expose-unparse branch June 15, 2023 00:17
vhata pushed a commit to discord/go-jsonnet that referenced this pull request Aug 30, 2024
@charleskorn @tomwilkie @vhata
Expose "unparse", FormatNode and RawAST (google#710)
a24c8ad 
* Export FormatNode so external users can pretty print an AST

Signed-off-by: Tom Wilkie <tom@grafana.com>

* Expose RawAST function.

Signed-off-by: Tom Wilkie <tom@grafana.com>

* Add comment

Signed-off-by: Tom Wilkie <tom@grafana.com>

---------

Signed-off-by: Tom Wilkie <tom@grafana.com>
Co-authored-by: Tom Wilkie <tom@grafana.com>
@BrewTestBot BrewTestBot mentioned this pull request May 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@charleskorn @sparkprime @coveralls @tomwilkie